robertlipe [Wed, 23 Oct 2013 01:49:39 +0000 (01:49 +0000)]
Take another run at NMN4.
robertlipe [Tue, 22 Oct 2013 02:33:15 +0000 (02:33 +0000)]
Pad internal buffer to appease -fsanitize=address. format_garmin_xt_decrypt_trk_blk is definitely going one byte too deep on that final byte and this is probably going to come back to byte me.
robertlipe [Tue, 22 Oct 2013 00:24:56 +0000 (00:24 +0000)]
Revert nmn4 change for now. I'll deal with it later.
robertlipe [Sun, 20 Oct 2013 23:31:16 +0000 (23:31 +0000)]
Make Navigon reader use QString more effectively.
robertlipe [Wed, 16 Oct 2013 18:15:48 +0000 (18:15 +0000)]
Scratch in waypoint proximity in Garmin GPX writer.
robertlipe [Sun, 6 Oct 2013 21:12:04 +0000 (21:12 +0000)]
Warning cleanpus from Conrad.
robertlipe [Thu, 3 Oct 2013 00:43:34 +0000 (00:43 +0000)]
Fix leak I introdued in new "obvious" code yesterday. Brace ourselves for
more of these soon...
robertlipe [Wed, 2 Oct 2013 04:59:49 +0000 (04:59 +0000)]
Update .pro file from Gerhard.
robertlipe [Wed, 2 Oct 2013 03:55:13 +0000 (03:55 +0000)]
Bring in some of the straight-forward pieces from NEW_STRINGS work.
robertlipe [Tue, 1 Oct 2013 04:32:48 +0000 (04:32 +0000)]
A completely mechanical search and replace to swap the first argument
for an xml_generic callback with a typdef that can be swapped at compile
time.
Yes, this is a hint of things to come to reduce future bulky merges.
robertlipe [Mon, 23 Sep 2013 02:51:49 +0000 (02:51 +0000)]
Compilation fixes.
robertlipe [Mon, 23 Sep 2013 02:45:37 +0000 (02:45 +0000)]
Land QString changes that don't require (blatant) conditional compilation
that are really mechanical.
robertlipe [Mon, 23 Sep 2013 02:40:24 +0000 (02:40 +0000)]
Make unicsv a little more QString ready internally.
robertlipe [Fri, 20 Sep 2013 20:22:32 +0000 (20:22 +0000)]
Bring forward uncontested change from NEW_STRINGS work to fix non-NEW_STRINGS build break.
robertlipe [Fri, 20 Sep 2013 05:21:25 +0000 (05:21 +0000)]
Commit the least contestable part of a CL I have in progress. Abandon the idea of a stepping stone "Strings" class. Just go straight to QString, currently behind a #define.
robertlipe [Thu, 19 Sep 2013 22:34:42 +0000 (22:34 +0000)]
Tweak testo to use more common stdout capture.
robertlipe [Thu, 19 Sep 2013 19:45:29 +0000 (19:45 +0000)]
Guilhem Bonnefile tweaks (old) Magellan Explorist PMGNCMD,END issues.
robertlipe [Wed, 18 Sep 2013 05:17:49 +0000 (05:17 +0000)]
Warning fixes from Conrad.
tsteven4 [Wed, 18 Sep 2013 00:36:46 +0000 (00:36 +0000)]
add utf-8 bom check and well-formed xml check to testo.
robertlipe [Tue, 17 Sep 2013 22:58:07 +0000 (22:58 +0000)]
Warning cleanups from Conrad.
tsteven4 [Tue, 17 Sep 2013 01:12:47 +0000 (01:12 +0000)]
change illegal xml character stripping from QRegExp/QRegularExpression to QTextCodec for efficiency. Thanks Conrad.
robertlipe [Sun, 15 Sep 2013 21:51:42 +0000 (21:51 +0000)]
Preserve note for future possibilities of strip_html.
robertlipe [Sun, 15 Sep 2013 18:44:12 +0000 (18:44 +0000)]
More pulling at removing C strings internally: unicsv_print_str and strenquote.
A victim of this is the seemingly unused sportsim format. It was doing
stupid things in the format definition with high byte characters and
unclear encodings. After a few hours trying to save it, I just chopped it.
robertlipe [Sun, 15 Sep 2013 07:18:39 +0000 (07:18 +0000)]
Replace guts of manual trimmed_strdup in tef reader. Reduce type thrash.
robertlipe [Sun, 15 Sep 2013 07:17:27 +0000 (07:17 +0000)]
Remove open-coded Vector in unicsv. Make better use of QString internally.
robertlipe [Sun, 15 Sep 2013 06:15:22 +0000 (06:15 +0000)]
Commit 'ptesto', a script for running valgrinds in parallel. Really crude,
but still kind of handy.
robertlipe [Sun, 15 Sep 2013 05:50:21 +0000 (05:50 +0000)]
Correct leak in bcr that I just introduced when I partially rolled back a failed experiment in making S1 and S2 into QStrings.
robertlipe [Sun, 15 Sep 2013 05:41:21 +0000 (05:41 +0000)]
A bulky, but rather brainless pass at treating the important strings in
struct waypoint as a class instead of C string. Of course, that struct
has one member - a C string - but this starts to hightlight the places
that are going to be problem areas for us.
With NEW_STRINGS turned on, we basically run, but suffer from a double
encoding of non-ascii strings. Every format seems to be affected, so
it's probably in CET somewhere. This isn't a QString thing in any obvious
way, as the underlying data types are still actually C Strings.
From here, additional passes can be made, either turning the individual
string pointer conversions off and whacking on a few files at a time or
going full money and making String a QString.
It does highlight the need for better vararg-style functions like warning,
fatal, and our debugging printfs to to know about stream operators.
robertlipe [Sat, 14 Sep 2013 23:49:03 +0000 (23:49 +0000)]
Fixes for optionsdlg: only use ranges when we HAVE ranges (and they're not equal). Let help link directly to the correct page.
Whitespace cleanup.
tsteven4 [Fri, 13 Sep 2013 20:26:47 +0000 (20:26 +0000)]
catch a straggler up with qt include renaming.
tsteven4 [Thu, 12 Sep 2013 22:14:07 +0000 (22:14 +0000)]
add xmlstreamwriter methods analogous to QXmlStreamWriter that strip illegal characters.
tsteven4 [Thu, 12 Sep 2013 02:52:40 +0000 (02:52 +0000)]
Get the gui ready for Qt5 while maintaining support for Qt4.
tsteven4 [Thu, 12 Sep 2013 02:45:53 +0000 (02:45 +0000)]
catch gui translation files up with recent source renaming and UpgradeCheck class work.
robertlipe [Wed, 11 Sep 2013 08:42:06 +0000 (08:42 +0000)]
Minor internal changes to make new_strings land better.
robertlipe [Wed, 11 Sep 2013 07:46:08 +0000 (07:46 +0000)]
Fix mem leak I introduced earlier tonight (this morning?) in ozi.
robertlipe [Wed, 11 Sep 2013 05:06:34 +0000 (05:06 +0000)]
Pull out a little more char* from our core infrastructure. Add shims to turn down case_ignore_strmp and case_ignore_strncmp().
Tweak reference files to deal with more correct(?) ordering in edge cases.
Start sketching a shim layer for shortname, description, and text, but increasingly I'm of the opinion that our only options are either do it all in one submit (eeek!) or to add additional members of struct waypt that are allocated/copied at waypt_add time so we can then at least separate readers and writers. Instinct tells me the latter will result in harsh punishment as we'll have members that are out of sync and it will be difficult to flush them out. So substantial parts of this CL may get tossed.
robertlipe [Wed, 11 Sep 2013 01:17:05 +0000 (01:17 +0000)]
Steve replaces use of deprecated QHttp with QNetworkAccessManager.
robertlipe [Tue, 10 Sep 2013 16:59:53 +0000 (16:59 +0000)]
Peter Popovec tweaks gtrnctr to fix sometimes missing lap info on write.
robertlipe [Mon, 9 Sep 2013 17:30:01 +0000 (17:30 +0000)]
Remove explicit xstrdup(CSTR... in favor of helper.
robertlipe [Mon, 9 Sep 2013 01:38:37 +0000 (01:38 +0000)]
Style Cleanup from last commit.
robertlipe [Mon, 9 Sep 2013 01:37:51 +0000 (01:37 +0000)]
Dirk Stitchling adds support for Navin/ZNEX miniHomer 2.8 with 10Hz time.
robertlipe [Sat, 7 Sep 2013 07:38:00 +0000 (07:38 +0000)]
Fix (probably) memory leak in xmltag converion.
robertlipe [Fri, 6 Sep 2013 20:38:11 +0000 (20:38 +0000)]
Move remaining char*'s in xmltag to QStrings. Tweak various callers and
copy ctors. vtesto on CentOS 6.4 seems no worse for the wear.
robertlipe [Fri, 6 Sep 2013 19:54:37 +0000 (19:54 +0000)]
Remove some read-only struct members in xml_tag. Passes vtesto.
robertlipe [Fri, 6 Sep 2013 19:40:51 +0000 (19:40 +0000)]
Fix another new/xfree mismatch.
robertlipe [Fri, 6 Sep 2013 19:27:03 +0000 (19:27 +0000)]
Correct allocation in xml_tag pseudo copy constructor.
robertlipe [Fri, 6 Sep 2013 19:15:28 +0000 (19:15 +0000)]
A very conservative move of xml_tag into a class of its own with
headers of its own. Tweak xmalloc/xfree to new/delete. Regenerate deps.
tsteven4 [Wed, 4 Sep 2013 00:19:06 +0000 (00:19 +0000)]
fix waypoint counting errors in tpo and igc readers.
add a filter to check the counts against the lists.
tsteven4 [Mon, 2 Sep 2013 13:02:46 +0000 (13:02 +0000)]
fix memory leaks in cup, easygps, mapsend, osm, pcx and skyforce exposed by test-all, valgrind and patience.
tsteven4 [Sun, 1 Sep 2013 18:46:42 +0000 (18:46 +0000)]
fix issue with naviguide reader double counting route waypts.
tsteven4 [Sun, 1 Sep 2013 17:23:02 +0000 (17:23 +0000)]
fix bug in garmin_txt reader that could result in uninitialised value(s) being used when the input does not contain "Date Modified" data.
tsteven4 [Sun, 1 Sep 2013 14:29:29 +0000 (14:29 +0000)]
fix iblue styles, writing was causing usage of uninitialised byte(s).
fix iblue style prologue to match written fields, text taken from 2010-09-13 email.
modify mkstyle.sh to produce code compatible with our astylerc options.
tsteven4 [Sun, 1 Sep 2013 13:19:35 +0000 (13:19 +0000)]
improve support for testo running from alternate directories.
tsteven4 [Sat, 31 Aug 2013 00:09:51 +0000 (00:09 +0000)]
add option to capture valgrind output in a log file.
tsteven4 [Fri, 30 Aug 2013 21:25:48 +0000 (21:25 +0000)]
fix some url related memory leaks.
add constructor for UrlLink from char*.
robertlipe [Fri, 30 Aug 2013 18:45:05 +0000 (18:45 +0000)]
Add valgrind leak suppressiosn for Fedora 18 to improve signal:noise.
Inspired by http://wiki.wxwidgets.org/Valgrind_Suppression_File_Howto
I'm not terribly confident these are as tight as can be (and I fear they
may be too loose in come cases) but it really helps "interesting" issues
pop out over system library loss.
robertlipe [Fri, 30 Aug 2013 18:19:26 +0000 (18:19 +0000)]
Remove unnecessary strdup in garmin_gpi.
robertlipe [Fri, 30 Aug 2013 05:08:34 +0000 (05:08 +0000)]
Fix obscure leak in GPX reader that I introduced. Combo.gpx from humminbird
now doesn't lose 80K.
Tested:
Manual inspection of valgrind --show-leaks on that specific file.
Full valgrind on Fedora.
tsteven4 [Wed, 28 Aug 2013 12:58:47 +0000 (12:58 +0000)]
report errors detected by QXmlStreamReader in the geo reader.
avoid infinite loop with malformed input in the geo reader.
avoid segmentation faults with malformed input in the geo reader.
tsteven4 [Wed, 28 Aug 2013 01:58:21 +0000 (01:58 +0000)]
correct comment about readElementText behavior.
tsteven4 [Wed, 28 Aug 2013 01:29:35 +0000 (01:29 +0000)]
add error checking QXmlStreamReader errors in xmlgeneric.
robertlipe [Mon, 26 Aug 2013 16:21:36 +0000 (16:21 +0000)]
Improve coment re:setCodecForCStrings.
robertlipe [Mon, 26 Aug 2013 00:15:56 +0000 (00:15 +0000)]
Gerhard brings MSVC up to speed.
Resync GPSBabel.pro
Kill mkwintesto
Various MSVC weirdness.
A change in main to set character encoding that really doesn't make sense
to me since he changed only the <Qt5 case and he's on Qt5.
robertlipe [Sun, 25 Aug 2013 21:25:07 +0000 (21:25 +0000)]
Another fix in gpx.cc. With this, vtesto runs to completion on Ubuntu 12.04.
robertlipe [Sun, 25 Aug 2013 20:53:40 +0000 (20:53 +0000)]
Fix use-after-read that I just introduced in gpx.cc
robertlipe [Sun, 25 Aug 2013 20:12:56 +0000 (20:12 +0000)]
Replace a little-used Date field in unicsv with QDateTime for little reason
other than I was looking at it for the test failure and it was unnecessarily
unsightly.
robertlipe [Sun, 25 Aug 2013 19:56:00 +0000 (19:56 +0000)]
Lock unicsv test to UTC.
robertlipe [Sun, 25 Aug 2013 19:29:07 +0000 (19:29 +0000)]
Actually commit leak fix I just told Steve I committed before lunch. {blush}
tsteven4 [Sun, 25 Aug 2013 18:55:19 +0000 (18:55 +0000)]
add error detection for navicache reader.
robertlipe [Sun, 25 Aug 2013 18:48:57 +0000 (18:48 +0000)]
Another cleanup pass on GPX reader. Eliminate vmem and several redundant
QString->C string roundtrips, making them explicit where needed.
tsteven4 [Sun, 25 Aug 2013 18:27:44 +0000 (18:27 +0000)]
Actually use autoheader to generate config.h.in instead of manual a manual edit.
It looks like this hasn't been done for a while.
tsteven4 [Sun, 25 Aug 2013 17:00:45 +0000 (17:00 +0000)]
rip expat out of the build system.
note that msvc/GPSBabel.vcxproj still needs to be updated to do this.
tsteven4 [Sun, 25 Aug 2013 14:13:45 +0000 (14:13 +0000)]
gpx reader based on QXmlStreamReader goes live.
robertlipe [Sun, 25 Aug 2013 04:27:45 +0000 (04:27 +0000)]
Rename GUI *.cpp to *.cc to match convention in core.
tsteven4 [Sat, 24 Aug 2013 01:51:54 +0000 (01:51 +0000)]
checkpoint new gpx reader based on QXmlStreamReader instead of expat.
the new gpx reader is disabled.
tsteven4 [Fri, 23 Aug 2013 23:10:51 +0000 (23:10 +0000)]
eliminate weird input mode of gpx reader.
add a test to make sure standard input works.
robertlipe [Fri, 23 Aug 2013 17:23:31 +0000 (17:23 +0000)]
Florian Unger adds rptname, rptdigit options to tranform filter.
robertlipe [Fri, 23 Aug 2013 17:07:40 +0000 (17:07 +0000)]
How many times do I have to kill axim and psp? Die, die, die!
robertlipe [Fri, 23 Aug 2013 04:19:39 +0000 (04:19 +0000)]
Delete some dead code.
robertlipe [Fri, 23 Aug 2013 03:57:59 +0000 (03:57 +0000)]
Drop dead uuid code.
robertlipe [Fri, 23 Aug 2013 03:48:22 +0000 (03:48 +0000)]
Add geocaching coverage to unicsv reader/writer test.
robertlipe [Fri, 23 Aug 2013 03:08:48 +0000 (03:08 +0000)]
Minor warning cleanups for Fedora.
robertlipe [Fri, 23 Aug 2013 03:05:37 +0000 (03:05 +0000)]
Add a KML read test, lame as it is...
robertlipe [Fri, 23 Aug 2013 03:01:02 +0000 (03:01 +0000)]
Whittle away a few more C-style date handlers.
tsteven4 [Thu, 22 Aug 2013 12:45:45 +0000 (12:45 +0000)]
fix another link related memory issue with the gpx reader.
tsteven4 [Thu, 22 Aug 2013 01:19:47 +0000 (01:19 +0000)]
fix a bug in the gpx reader that could cause the character data from the wrong element to become associated with the link/text element.
robertlipe [Wed, 21 Aug 2013 19:46:49 +0000 (19:46 +0000)]
Kludge around probably TZ issue that I introduced in hiketech.
robertlipe [Wed, 21 Aug 2013 04:24:40 +0000 (04:24 +0000)]
Convert remaining users (glogbook, hiketech) of xmlgeneric
writer to XMLStreamwriter. Drop a whole lot of (kinda dumb) code.
tsteven4 [Tue, 20 Aug 2013 12:10:43 +0000 (12:10 +0000)]
correct error in computing time spans related to DST.
add toMSecsSinceEpoch() for Qt versions before 4.7.
robertlipe [Tue, 20 Aug 2013 06:13:43 +0000 (06:13 +0000)]
OK, the doc is self-correcting when you don't include explict references
to formats that just got deleted...
robertlipe [Tue, 20 Aug 2013 05:19:16 +0000 (05:19 +0000)]
Actually commit the astyle change I spoke of earlier.
robertlipe [Tue, 20 Aug 2013 03:19:47 +0000 (03:19 +0000)]
The reaper comes for little-used and/or pain in the neck formats.
See depreecated/README for details.
tsteven4 [Sun, 18 Aug 2013 23:34:32 +0000 (23:34 +0000)]
tweak datetime operator overload.
tsteven4 [Fri, 16 Aug 2013 17:13:15 +0000 (17:13 +0000)]
don't use windows ddks that won't work, e.g. the one with the cross compiler on fedora 18.
robertlipe [Fri, 16 Aug 2013 06:19:05 +0000 (06:19 +0000)]
Remove another implicit time_t conversion.
robertlipe [Fri, 16 Aug 2013 05:48:01 +0000 (05:48 +0000)]
A surpisingly clean bill of health from valgrind on new navicache reader.
Have some warning cleanups at no extra cost.
robertlipe [Fri, 16 Aug 2013 05:30:55 +0000 (05:30 +0000)]
Replace use of Expat with QXmlStreamReaader in navicache.cc.
tsteven4 [Fri, 16 Aug 2013 04:42:15 +0000 (04:42 +0000)]
slightly cleaner fix for Qt 4.6.
tsteven4 [Thu, 15 Aug 2013 23:05:01 +0000 (23:05 +0000)]
compatibility fix for Qt 4.6.
tsteven4 [Thu, 15 Aug 2013 22:38:22 +0000 (22:38 +0000)]
remove insistence that we have expat for kml, gtrnctr, ignrando, wfff, osm now that those readers don't use it.